Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docker): AS casing match FROM #2621

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

PixnBits
Copy link
Contributor

Summary

Avoid a minor warning from Docker when building.

While Dockerfile keywords can be either uppercase or lowercase, mixing case styles is not recommended for readability.

https://docs.docker.com/reference/build-checks/from-as-casing/

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

Screenshots

$ docker build .
...
 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)                                               0.1s
 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 11)                                              0.1s
...

$ docker version
Client: Docker Engine - Community
 Version:           27.2.1
...

Server: Docker Engine - Community
 Engine:
  Version:          27.2.1
...

avoid a warning from Docker when building
@PixnBits PixnBits requested a review from a team as a code owner October 26, 2024 19:33
@mnaumanali94 mnaumanali94 enabled auto-merge (squash) November 26, 2024 06:02
@mnaumanali94 mnaumanali94 self-requested a review November 26, 2024 06:02
@mnaumanali94 mnaumanali94 merged commit c6a8f8a into stoplightio:master Nov 26, 2024
7 checks passed
dgellow added a commit to stainless-api/prism that referenced this pull request Jan 16, 2025
* fix: version update and bundled_issue changes (stoplightio#2577)

* chore(ci): release please without root again (stoplightio#2558)

* chore(ci): release please without root (stoplightio#2583)

* chore(ci): back to release please without root p2 (stoplightio#2584)

* chore(ci): revert attempt to fix release please (stoplightio#2587)

* chore: release master (stoplightio#2586)

Co-authored-by: lukasz.zazulak <lukasz.zazulak@smartbear.com>

* fix: reverted changes and bump the JSON version (stoplightio#2598)

* chore: release master (stoplightio#2588)

Co-authored-by: sb-rohitdesai <rohitkumar.desai@smartbear.com>

* chore(deps): bump micromatch from 4.0.5 to 4.0.8 (stoplightio#2597)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump axios from 1.7.2 to 1.7.7 (stoplightio#2604)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump fast-xml-parser from 4.3.2 to 4.4.1 (stoplightio#2570)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(readme): update roadmap links (stoplightio#2555)

* feat: add --seed CLI flag for deterministic generation of dynamic examples (stoplightio#2594)

* chore(deps-dev): bump json-schema-faker from 0.5.6 to 0.5.8 (stoplightio#2627)

* chore: fix circle ci config (stoplightio#2628)

* chore: release master (stoplightio#2606)

* fix(http): update json-path plus in http

* chore: release master (stoplightio#2629)

* chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 (stoplightio#2635)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump micromatch from 4.0.5 to 4.0.8 (stoplightio#2633)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump axios from 1.7.2 to 1.7.7 (stoplightio#2631)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* refactor(docker): AS casing match FROM (stoplightio#2621)

* fix(Docker): use tini to handle kernel signals (stoplightio#2622)

* chore(deps): bump split2 and @types/split2 (stoplightio#2615)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump form-data from 4.0.0 to 4.0.1 (stoplightio#2616)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump tmp from 0.2.1 to 0.2.3 (stoplightio#2613)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump braces from 3.0.2 to 3.0.3 (stoplightio#2632)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump nanoid from 3.3.7 to 3.3.8 (stoplightio#2646)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump @stoplight/yaml from 4.2.3 to 4.3.0 (stoplightio#2641)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump husky from 8.0.3 to 9.1.7 (stoplightio#2637)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Run yarn install

* Add stainless github CI

* Use explicit deps versions

* Fix prettier issue

* Fix

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: SB-rohitdesai <165134671+SB-rohitdesai@users.noreply.github.com>
Co-authored-by: Brenda Rearden <brendarearden@gmail.com>
Co-authored-by: lukaszzazulak <155975313+lukaszzazulak@users.noreply.github.com>
Co-authored-by: Stoplighticus Roboticus <43760305+stoplight-bot@users.noreply.github.com>
Co-authored-by: lukasz.zazulak <lukasz.zazulak@smartbear.com>
Co-authored-by: sb-rohitdesai <rohitkumar.desai@smartbear.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ilana Shapiro <ishapiro00@gmail.com>
Co-authored-by: Bogdan O. <bogdan.oniga@accelins.com>
Co-authored-by: Nauman <mnaumanali94@gmail.com>
Co-authored-by: Nick Oliver <git@pixnbits.org>
Co-authored-by: Nick Oliver <i@pixnbits.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants